[GitOps Catalog] Add Cilium to gitops-catalog #162
Conversation
|
I just added the GPG key to my GitHub profile settings, and now commits are showing up as verified. |
|
Hey @dipu989! Thank you for your contribution! I want to hold off this PR since enabling Cilium has a few implications in the cluster and pod lifecycle (chances are, after installing it, you might need to restart all pods so they can pick up Cilium's networking instead of the default flow or something along those lines). Internally we're discussing about the best way to achieve this and where in the lifecycle of Kubefirst would be the time to install it. Allow us a few days to get to a conscious answer. |
|
@patrickdappollonio Interesting problem. |
|
So after @patrickdappollonio discussed with the team, it seems like we are fine with adding it as it is. Folks will do whatever they have to do to make it work if there are some after-steps. Thanks a lot for the contribution, and sorry for the long delay on that one. |
|
@dipu989: if you DM me on our Slack community, I'll send you some swag as a token of our appreciation for being a contributor. |
|
@fharper Thank you for the appreciation 🎉 |
Issue link
I've put together a PR to add Cilium to the GitOps catalog.
This is my first time contributing to the konstructio repo, so I'd really appreciate it if you could take a look 👀. Open to any feedback or suggestions for improvement 🚀.
By the way, the video from @johndietz and @fharper on how to add an app to the GitOps catalog was super fun to watch and made it easy to follow along, so this PR is a result of that 🤞